Closed bommaritom closed 1 year ago
Tested both the shepp Logan demo and readthedocs. Everything works fine. @cabouman Can we merge this in ASAP?
Marco, did you test the functionality of the new image_slice_offset
argument in order to make sure it functions properly?
Hi Prof. Bouman, I have a demo file that runs a forward projection both without image_slice_offset set, with a positive value for image_slice_offset, and with a negative value for image_slice_offset. This demo file behaves as expected. I can add this demo file to the pull request if necessary.
That's OK. I ran some test scripts, and it ran fine. I just wanted to make sure that you had tested the new feature.
These changes include the previously discussed changes to cone3D.py, as well as two other minor changes I've made in passing. Namely I added comments to a "test" file I had created in the past, and I added some text to some .rst (read-the-docs) files.
image_slice_offset=0.0
toproject
arguments. Add corresponding functionality on lines 641-642.dev_scripts
; copy-paste MBIR theory explanation from svmbir.Tested: demo_3D_shepp_logan.py, demo_mace3D_fast.py, install_docs.sh