Automatic behavior for 'delta_det_channel', 'delta_det_row'

[bommaritom]

This pull request implements the following behavior in 'lamino' and 'project':

• Change default values of 'delta_det_channel' and 'delta_det_row' from 1.0 to None.
• Set 'delta_det_channel' and 'delta_det_row' using the method 'auto_delta_det_channel_row', which does the following:
  • If 'delta_det_channel' and 'delta_det_row' are both set to None, set both to 1.0.
  • If one of 'delta_det_channel' and 'delta_det_row' is set to None, set that one to be equal to the other, and raise a warning.
  • If both of 'delta_det_channel' and 'delta_det_row' are set, use those values.

We are implementing this change because it is the desired automatic behavior for 'delta_det_channel' and 'delta_det_row'.

[cabouman]

Marco, You are confused. The entire point here is that we don’t need to make any changes to these defaults.

So you should not touch anything in cone3D.py. The current defaults of 1.0 are fine.

You only need to create the new laminography functions in a separate file. Charlie

On Feb 10, 2023, at 11:06 AM, Marco Bommarito @.***> wrote:

@bommaritom https://github.com/bommaritom requested your review on: #119 https://github.com/cabouman/mbircone/pull/119 Automatic behavior for 'delta_det_channel', 'delta_det_row'.

— Reply to this email directly, view it on GitHub https://github.com/cabouman/mbircone/pull/119#event-8491459528, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFY3FKABJ7QYLOZW2EQADNLWWZRPLANCNFSM6AAAAAAUX636TM. You are receiving this because your review was requested.