Closed dyang37 closed 11 months ago
Thank you for merging in the fix! Does the readthedocs build work now?
Diyu
From: Charles A Bouman @.> Sent: Tuesday, December 5, 2023 9:58 AM To: cabouman/mbircone @.> Cc: Yang, Diyu @.>; Author @.> Subject: Re: [cabouman/mbircone] yaml file for readthedocs (PR #154)
---- External Email: Use caution with attachments, links, or sharing data ----
Merged #154https://github.com/cabouman/mbircone/pull/154 into master.
— Reply to this email directly, view it on GitHubhttps://github.com/cabouman/mbircone/pull/154#event-11154576749, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB2Q7OFIZ4OQRWPKMMKEDPTYH4ZA3AVCNFSM6AAAAABAG773R2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGE2TINJXGY3TIOI. You are receiving this because you authored the thread.Message ID: @.***>
Yep, works great. Charlie
From: Diyu Yang @.> Date: Tuesday, December 5, 2023 at 10:37 AM To: cabouman/mbircone @.> Cc: Charles A Bouman @.>, State change @.> Subject: Re: [cabouman/mbircone] yaml file for readthedocs (PR #154) Thank you for merging in the fix! Does the readthedocs build work now?
Diyu
From: Charles A Bouman @.> Sent: Tuesday, December 5, 2023 9:58 AM To: cabouman/mbircone @.> Cc: Yang, Diyu @.>; Author @.> Subject: Re: [cabouman/mbircone] yaml file for readthedocs (PR #154)
---- External Email: Use caution with attachments, links, or sharing data ----
Merged #154https://github.com/cabouman/mbircone/pull/154 into master.
— Reply to this email directly, view it on GitHubhttps://github.com/cabouman/mbircone/pull/154#event-11154576749, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB2Q7OFIZ4OQRWPKMMKEDPTYH4ZA3AVCNFSM6AAAAABAG773R2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGE2TINJXGY3TIOI. You are receiving this because you authored the thread.Message ID: @.***>
— Reply to this email directly, view it on GitHubhttps://github.com/cabouman/mbircone/pull/154#issuecomment-1841040779, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFY3FKCPHR74TSAOQOEMHC3YH45TVAVCNFSM6AAAAABAG773R2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBRGA2DANZXHE. You are receiving this because you modified the open/close state.Message ID: @.***>
This PR fixes the readthedocs build. Wenrui tested on his forked mbircone repo and it seems to work.