search

cabouman / mbircone

BSD 3-Clause "New" or "Revised" License
11 stars 9 forks source link

MACE bug fix: incorrect tuple unpacking for denoiser_args inside mace3D #36

Closed dyang37 closed 3 years ago

dyang37 commented 3 years ago

This bug is recently spotted when I try to use denoiser functions that accepts multiple input arguments (for example, the bm3d_multi_node denoiser function in demo/denoiser_utils.py from branch Lilly_experiments).

Basically what happened is that the way that we unpack the tuple denoiser_args inside denoiser_wrapper is incorrect. As a result, when multiple elements exist in denoiser_args, all elements other than the first one will get ignored. This is not spotted before because the only denoiser function cnn_denoiser we used to test mace accepts only one additional argument.

The fix is in branch bug fix/mace_arg_parse. It's been tested and it works.

dyang37 commented 3 years ago

PR submitted.

dyang37 commented 3 years ago

Closed because PR merged into master.