Memory fix patch - Githubissues

dyang37 commented 2 years ago

This is (hopefully) the last merge for the memory fix. This PR contains Wenrui's PR #57 for readthedoc fix. Additionally, this PR contains the following memory allocation fix:

In python recon() function, when init_image is provided as a scalar, the construction of the corresponding 3D array is moved from cone3D.py to interface_cy.py to avoid unnecessary mem alloc and copy of 3D memory space.
Move all axes swapping into Cython interface.

Both fixes above follows the convention/implementation of svmbir.

Testing: Tested with both demo_3D_shepp_logan.py and demo_mace3D.py. Memory usage: Memory usage (measured before Cython interface invoking C code subroutine) drops from 4075MB down to 2712MB for a problem with sino shape = 144x512x512, recon shape = 799x473x473.

cabouman commented 2 years ago

Wenrui, can you please test this? If it works, I will accept the PR.

DamonLee5 commented 2 years ago

Sure. I will test it now.

DamonLee5 commented 2 years ago

Both demo_3D_shepp_logan.py and demo_mace3D.py work on my end. Diyu do you have any scripts for us to test the memory usage?

cabouman / mbircone

Memory fix patch #58