search

cabouman / mbircone

BSD 3-Clause "New" or "Revised" License
11 stars 9 forks source link

Hotfix docs demos #94

Closed bommaritom closed 2 years ago

bommaritom commented 2 years ago

Hi all,

This is a 'hotfix' to my recent pull request that had some unfinished business.

Changes:

I started to create a 'test' suite, but a test suite would need to access the 'demo_utils' module in order to run. So, I have left 'debug_forward_proj.py' in the demo suite, knowing that it should be divided out into its own suite that also has access to 'demo_utils'.

Note that the multinode demo files still need to be updated and tested, since they previously relied on methods that are now deprecated.

dyang37 commented 2 years ago

Thanks Marco. I'll test this later in the afternoon. Regards, Diyu

From: Marco Bommarito @.> Sent: Tuesday, October 4, 2022 11:39 AM To: cabouman/mbircone @.> Cc: Diyu Yang @.>; Review requested @.> Subject: Re: [cabouman/mbircone] Hotfix docs demos (PR #94)

---- External Email: Use caution with attachments, links, or sharing data ----

@bommaritomhttps://github.com/bommaritom requested your review on: #94https://github.com/cabouman/mbircone/pull/94 Hotfix docs demos.

— Reply to this email directly, view it on GitHubhttps://github.com/cabouman/mbircone/pull/94#event-7517791180, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB2Q7OAFXE2XK7FFKTUDXTTWBRFRZANCNFSM6AAAAAAQ4WMTKQ. You are receiving this because your review was requested.Message ID: @.***>

cabouman commented 2 years ago

Diyu, did you test the multinode demo?

dyang37 commented 2 years ago

Diyu, did you test the multinode demo?

Yes. I'm modifying the multinode script so that it is both compatible with recent changes due to ROR computation, and also matches with the style of the 3D shepp Logan demo (except for the multinode part).

I'll notify you when the testing is finished.

dyang37 commented 2 years ago

Everything has been tested. I think it is OK to accept the PR at this point.

cabouman commented 2 years ago

Oh Shoot! I forgot to push my fixes before I accepted the PR. I'm going to have to do another PR fix.

cabouman commented 2 years ago

OK, you shouldn't ever do what I just did. I had to merge in the fixes, and then do a direct push into the master branch.