cabouman / svmbir

Fast code for parallel or fan beam tomographic reconstruction
BSD 3-Clause "New" or "Revised" License
21 stars 8 forks source link

Fan beam forward models #247

Closed sjkisner closed 2 years ago

sjkisner commented 2 years ago

I now have fan beam forward models for the both curved and flat detectors. For the geometry argument I'm considering the following names:

['parallel',
'fan-curved',
'fan-flat',
'fan']   # have this default to 'fan-curved' and issue a warning

Any alternate suggestions?

cabouman commented 2 years ago

Jordan, this looks fine, but I think you can just use the first three since 'fan' is ambiguous.

cabouman commented 2 years ago

We added a depreciation warning for the fan option and mapped it to fan-curved. So this is done.