Fix for notice in WooCommerce wizard

cabrerahector / wordpress-popular-posts

WordPress Popular Posts - A highly customizable WordPress widget that displays your most popular posts.

https://wordpress.org/plugins/wordpress-popular-posts/

GNU General Public License v2.0

279 stars 83 forks source link

Fix for notice in WooCommerce wizard #129

Closed limestreet closed 7 years ago

limestreet commented 7 years ago

There is a notice in WooCommerce wizard: Notice: Trying to get property of non-object in /var/www/html/beta/wp-content/plugins/wordpress-popular-posts/wordpress-popular-posts.php on line 675 I use:

WordPress v4.7.3
PHP 7.0.16
WooCommerce v2.6.14
WordPress Popular Posts v3.3.4

cabrerahector commented 7 years ago

Hi Patryk,

Thanks for the PR! Does this happen on WPP4 as well?

limestreet commented 7 years ago

The same behavior here: https://github.com/cabrerahector/wordpress-popular-posts/blob/wpp4/admin/class-wordpress-popular-posts-admin.php#L165 Do you want me to provide fix or you prefer to do it on your own?

cabrerahector commented 7 years ago

Do you want me to provide fix or you prefer to do it on your own?

Please do so. Thank you in advance for contributing!