search

cabrerahector / wordpress-popular-posts

WordPress Popular Posts - A highly customizable WordPress widget that displays your most popular posts.
https://wordpress.org/plugins/wordpress-popular-posts/
GNU General Public License v2.0
280 stars 83 forks source link

Removing unnecessary line-breaks causing spaces to appear in the browser #217

Closed zs-jakob closed 5 years ago

zs-jakob commented 5 years ago

Removing unnecessary line-breaks causing spaces to appear in the browser. Adding line-breaks makes the source look less messy. Problem is, browsers render these breaks as spaces :(

image

cabrerahector commented 5 years ago

This is a styling issue specific to your site so I'm afraid I'll have to reject this PR. You can use an HTML minification plugin (like Autoptimize) to remove all line breaks automatically.

zs-jakob commented 5 years ago

This is poor practice. Has nothing to do with my website specifically. Whitespace shouldn't exist inside within inline level elements in HTML unless it's intentional. Asking people to minimize their sources isn't a solution. I'll have to either keep a forked version of your plug-in, rewrite your CSS so these elements are blocks or do as you suggest which I think is an inappropriate solution.