Fix block-scoped declarations

[gloryit]

Fix block-scoped declarations (let, const, function, class) not yet supported outside strict mode

[cabrerahector]

Hi there,

Strict mode has been supported by all major browsers since IE 11. Could you please explain what these PRs "fix" in more detail?

[gloryit]

Hi there,

I know strict mode has been supported by all major browsers since IE 11. But some countries still use old browsers and i also get many warring from chrome version 45.

[cabrerahector]

Yeah, the thing is that the code you changed is related to 2 features that aren't supported by IE to begin with:

• Widget themes are not guaranteed to work on any versions of IE as it doesn't provide support for the Shadow DOM API.
• The image lazy loading feature doesn't work on IE as it doesn't support the IntersectionObserver API.

These changes you're proposing may only fix console notices but the actual features will still not work as intended for people using IE. There's also the fact that -according to statcounter.com- as of Jan. 2020 only 1.68% of users around the world are using IE to browse the web. Even the Safari browser, available only to MacOS & iOS users, is above IE in usage (17.21%).

So, I'm afraid I'll have to reject your PRs this time as I don't want to provide support for browsers that even Microsoft itself has stopped supporting officially and that only a handful of people are still using.

Regarding the notices you're seeing on Chrome v45: that version was released in September 2015. That's almost 5 years old now, and it's a whopping 37 releases behind the latest version (82.0, launched on 2020-02-01). You may want to consider upgrading (for a lot of reasons, not just for WPP). If these notices are still present after upgrading Chrome please let me know and I'll have a look.