search

cabrerahector / wordpress-popular-posts

WordPress Popular Posts - A highly customizable WordPress widget that displays your most popular posts.
https://wordpress.org/plugins/wordpress-popular-posts/
GNU General Public License v2.0
279 stars 83 forks source link

use mb_strlen(multi-byte safe) #304

Closed c2nprds closed 3 years ago

c2nprds commented 3 years ago

use mb_strlen and mb_substr method. check length of string is safe multi-byte safe.

ref: https://www.php.net/manual/en/function.mb-strlen.php ref: https://www.php.net/manual/en/function.mb-substr.php

cabrerahector commented 3 years ago

Hi @c2nprds,

So what does this fix / improve exactly? It'd be nice to have some context :P

Edit: please disregard my comment above, I had just woken up haha. Just checked your PR, looks good to me. Will do some tests after breakfast and if everything's alright will merge changes into master right away. Thanks for contributing! :)