search

cabservicesag / falsearch

TYPO3 - A simple search for FAL files.
GNU General Public License v2.0
4 stars 1 forks source link

TYPO3 7.6.12 Compatibility #2

Open christophlehmann opened 7 years ago

christophlehmann commented 7 years ago

Hey, the extension currently does not work with TYPO3 7.6.12, in the filelist module i get an exception:

1: PHP Warning: Declaration of Cabag\Falsearch\Xclass\Folder::getFiles($start = 0, $numberOfItems = 0, $filterMode = self::FILTER_MODE_USE_OWN_AND_STORAGE_FILTERS, $recursive = false) should be compatible with TYPO3\CMS\Core\Resource\Folder::getFiles($start = 0, $numberOfItems = 0, $filterMode = self::FILTER_MODE_USE_OWN_AND_STORAGE_FILTERS, $recursive = false, $sort = '', $sortRev = false) in .../ext/falsearch/Classes/Xclass/Folder.php line 0 (More information)

TYPO3\CMS\Core\Error\Exception thrown in file ...typo3_src-7.6.12/typo3/sysext/core/Classes/Error/ErrorHandler.php in line 111.

CDRO commented 7 years ago

Hey, thanks for your feedback, I think I have a working version somewhere, I'll try to update this asap.

In the mean time, you can fix your installation by adding the missing parameters to the function getFiles.

Regards

christophlehmann commented 7 years ago

With PHP 5.5 it's still working, so it's an issue with PHP 7.0

CDRO commented 7 years ago

This is probably also an issue in 5.6, since the importance of suche errors was upped from E_NOTICE to E_WARNING.

Anyways, this will be fixed.

mpm-derdogan commented 7 years ago

Any hints for this problem until the fixed version will be released?

bergischweb commented 7 years ago

With PHP 5.6 no problem. With PHP 7 the exception is thrown.

CDRO commented 7 years ago

Should be fixed in latest commit

bergischweb commented 7 years ago

Yes, I can acknowledge this.