cac-t-u-s / om-sharp

OM#: Visual Programming | Computer-assisted Music Compositon
https://cac-t-u-s.github.io
GNU General Public License v3.0
167 stars 14 forks source link

Handle MIDI channels greater than 16 in score objects #323

Closed j-bresson closed 2 years ago

j-bresson commented 2 years ago

Or prevent from setting them.

Currently it is possible to set any number through the inputs, but then so,e draw functionality crash (like drawing durations, or anything requiring the MIDI channel color)

j-bresson commented 2 years ago

See https://github.com/cac-t-u-s/om-sharp-users/issues/57

charlesneimog commented 2 years ago

If I could suggest something,

One option that would not just solve the problem of MIDI but some others is to open a new inlet with extras-data. I initially thought this was the function of the extras inlets. Instead of using the lchan to define pathnames (In my use and compositional things), I could use the extras-data.

In this extra inlet, the user could define things like ties cited on #102. Of course, the render function will not do anything with this informations.

I know this comment has a very personal bias rsrs.

j-bresson commented 2 years ago

This is what extras are for, in principle. Maybe they're just not flexible enough? For your case (pathnames) couldn't you just use TEXT-EXTRA?

charlesneimog commented 2 years ago

Hmmm, I had not understood that! I am sorry.

For some reason, I was thinking that all data in "extra inlet" was related with render something in the score.

Sorry again!

j-bresson commented 2 years ago

Yes, the text-extra is rendered in the score (as a text attached to a given score element). But you can also use it to hold some information... Does it work for you now?

charlesneimog commented 2 years ago

Yes, it works!

Just one question, if I use some class like my-extras and add it in extras inlet. Could it provide some problem? Or the functions to draw the score will always ignore it?

j-bresson commented 2 years ago

It should be no problem. Have you tried?

charlesneimog commented 2 years ago

Yes, it works!

So, sorry for my comment. I had not understood the extras inlet.

j-bresson commented 2 years ago

1ff2368825321a3201779a3ff33a959980e24737