String operator+= should use realloc.

[GoogleCodeExporter]

Paul Stoffregen: "This version avoids buffer overflow if more memory can't be 
allocated.  It also leverages the C library realloc() function which is vastly 
better when the user repetitively concatenates stuff onto a string since it can 
just grow the existing block if free space follows."

const String & String::operator+=( const String &other )
{
 _length += other._length;
 if ( _length > _capacity ) {
  char *newbuffer = (char *)realloc(_buffer, _length + 1);
  if (newbuffer) {
    _buffer = newbuffer;
    _capacity = _length;
  } else {
    // out of memory, avoid buffer overflow by leaving string unchanged
    _length -= other._length;
    return *this;
  }
 }
 strcat( _buffer, other._buffer );
 return *this;
}

Original issue reported on code.google.com by dmel...@gmail.com on 18 Aug 2010 at 8:58

[GoogleCodeExporter]

Original comment by dmel...@gmail.com on 25 Aug 2010 at 5:54

• Added labels: Milestone-0020
• Removed labels: Milestone-0019

[GoogleCodeExporter]

Original comment by dmel...@gmail.com on 5 Oct 2010 at 2:00

• Added labels: Milestone-0022
• Removed labels: Milestone-0020

[GoogleCodeExporter]

https://github.com/arduino/Arduino/commit/63f4021447231003f1c362b0f492756644aa31
65

Original comment by dmel...@gmail.com on 11 Dec 2010 at 8:25

• Changed state: Fixed