Fixed VS2015 error; snprintf std is now included

cacalabs / libcaca

💩 Colour ASCII Art Library

Do What The F*ck You Want To Public License

540 stars 71 forks source link

Fixed VS2015 error; snprintf std is now included #13

Closed HuxyUK closed 8 years ago

HuxyUK commented 8 years ago

Visual Studio's compiler (C++ 14) now includes a standard library version of snprintf

samhocevar commented 8 years ago

What error does this fix? I want to be cautious here, because I would like static libcaca libraries compiled with VS2015 to work with earlier versions of VS, too.

HuxyUK commented 8 years ago

It's a build error. The latest library used in VS2015 now produces a pragma warning error if snprintf is redefined (as it now has a correct implementation), thus preventing the build from completing.

As the earlier compilers did not provide this functionality, I would presume with this change that a static lib would fail on earlier versions.

samhocevar commented 8 years ago

Okay, it’s better to fix actual build errors than try to guard against potential incompatibilities. Thanks for the patch.