search

cacao-org / cacao

Compute And Control for Adaptive Optics
GNU General Public License v3.0
24 stars 9 forks source link

separate gain and leak in modal filter #29

Closed jaredmales closed 1 year ago

jaredmales commented 1 year ago

This modifies modalfilter.c so that gain and leak are fully independent , which I think is the proper form of the leaky integrator.

I tested this with the simulator on scexao-vispyr-bin2 with no noticeable change in behavior.

The effects of this should be subtle and probably negligible in the usual case where mult. coef. is close to 1. It's probably worth being correct, and this could help with things like transfer function analysis and gain optimization.

DasVinch commented 1 year ago

Agree 100% this is proper. Merging!