search

cacao-org / cacao

Compute And Control for Adaptive Optics
GNU General Public License v3.0
24 stars 9 forks source link

update ImageStream metadata on startup in modalfilter #44

Closed jaredmales closed 10 months ago

jaredmales commented 10 months ago

When modalfilter (mfilt) starts up it initializes several shmims (such as mgainfact). If these already exist, they are not recreated (so inode doesn't change) and are just re-initialized (e.g. to 1 for all modes in mgainfact). However, cnt0 and times are not updated and semaphores are not posted. So any listening processes, such as modal optimizers and guis, don't know that the arrays have changed.

This change updates cnt0, writetime, atime, and posts semaphores for the relevant shmims on mfilt startup.

DasVinch commented 10 months ago

Took the liberty to factor that with ImageStreamIO_UpdateIm calls.

The only difference is that only writetime is updated, not atime. Can change ISIO to address that if necessary.

jaredmales commented 10 months ago

Good for me. I have a proposal to add atime to UpdateIm in a non-breaking way. Will PR next.

On Mon, Dec 11, 2023, 14:00 Vincent Deo @.***> wrote:

Took the liberty to factor that with ImageStreamIO_UpdateIm calls.

The only difference is that only writetime is updated, not atime. Can change ISIO to address that if necessary.

— Reply to this email directly, view it on GitHub https://github.com/cacao-org/cacao/pull/44#issuecomment-1850880117, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZFZCHW4G4G46WQQF2MXZLYI5X7JAVCNFSM6AAAAABANSXJG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJQHA4DAMJRG4 . You are receiving this because you authored the thread.Message ID: @.***>