search

caccs / caccs.io

Site do Centro Acadêmico com calendário de datas de provas e trabalho e formulários para avaliação de disciplinas.
0 stars 0 forks source link

Docker feature #28

Closed eiguike closed 6 years ago

eiguike commented 6 years ago

Hello!

This pull-request contains the implementations needed to make Docker working properly in this Rails App, to accomplish this task, I had to modify some parameters into database.yml, added some files needed to create a docker image, documented how to use Docker and added new lines into .gitignore.

That's it! If you find something wrong, please let me know.

Thanks!

eiguike commented 6 years ago

Why this PR failed? :( @Darkkgreen

Jostavo commented 6 years ago

CircleCI is looking for a dev database called development and you're passing 'db'

Jostavo commented 6 years ago

Okay, so the problem is a little bit different than I initially thought: I guess we're probably doing something twice: once on CircleCI config file and once on Docker config file. I guess we should rewrite everything, leaving to CircleCI only testing stuff, while Docker should config the new environment

Jostavo commented 6 years ago

Wait what

eiguike commented 6 years ago

Resolving conflicts

Jostavo commented 6 years ago

Oh ok limão, dunno what I was thinking

Jostavo commented 6 years ago

Lmao* xd

eiguike commented 6 years ago

Docker working! @Darkkgreen could you please give the errors message from circle-ci? I can't access the link below.

Jostavo commented 6 years ago

Did you signup to CircleCI? Since you're in the same org as me, you do have access to it

Jostavo commented 6 years ago

We'll have to merge our PRs, since I changed CircleCI's config file. I guess we can merge this and fix our differences later (when I merge my PR). Or I can merge the other one and you pull the master changes into this one. Your call

CACCSBot commented 6 years ago
1 Warning
:warning: Big fucking PR

Checklist:

Generated by :no_entry_sign: Danger