search

cachapa / AerialDream

A screensaver for Android inspired on the one from the Apple TV
GNU General Public License v3.0
116 stars 27 forks source link

Replace fade transitions with something else #30

Closed cachapa closed 3 years ago

cachapa commented 4 years ago

The fade transition requires loading and playing two videos simultaneously which isn't supported in many devices in current use.

This needs to be rewritten so that only one video is loaded at a time, and a different transition must be found between videos.

Dreamescaper commented 3 years ago

Just an idea: Use same fade transition, but use last frame from the second video instead of video itself.

AlexDemzz commented 3 years ago

is it fix yet ?

N0rdmann commented 3 years ago

Maybe just give an option to disable the transition for the time being? I rather have a little pause between two vids than no 4K videos at all on my XH90 😥

cachapa commented 3 years ago

If only it would be that easy. The fade transitions are hardcoded and essentially require a rewrite of large portions just to get them out, not to mention making them configurable.

Dreamescaper commented 3 years ago

I have a working version without fade transition, I can submit the PR if that's acceptable.

Making it configurable is much harder indeed though.

cachapa commented 3 years ago

@Dreamescaper sounds good, I'd be happy to review your PR.