cachethq / Docker

A Dockerized version of Cachet.
https://cachethq.io
BSD 3-Clause "New" or "Revised" License
415 stars 280 forks source link

.env file is missing APP_KEY when using the `docker run` stanzas #303

Closed JonTheNiceGuy closed 6 years ago

JonTheNiceGuy commented 6 years ago

Following the https://docs.cachethq.io/docs/get-started-with-docker#section-running-cachet-docker-container-manually page, I found that the .env file is missing an APP_KEY= line.

I think the problem is here: https://github.com/CachetHQ/Docker/blob/master/entrypoint.sh#L188-L193

I think the opening line should be:

if [ -z "${APP_KEY}" ]; then

I've worked around it by dropping into the docker container using docker exec -it cachet bash and then docker restart cachet once it was done, but I just wanted to flag this for now...

wfjsw commented 6 years ago

Confirmed. Empty string is not null in bash.

djdefi commented 6 years ago

This breaks the script by default though with docker-compose, as we have it set to null as a placeholder there.