search

cachethq / cachet

🚦 The open-source status page system.
https://cachethq.io
MIT License
14.06k stars 1.56k forks source link

Error 500 -> Undefined variable: appAnalyticsPiwikURL #3144

Closed krollebol closed 6 years ago

krollebol commented 6 years ago

Yesterday I updated to the latest 2.4 git version. But there is an issue when Piwik is configured in Settings, resulting in error 500:

[2018-06-29 12:38:47] production.ERROR: ErrorException: Undefined variable: appAnalyticsPiwikURL in /var/www/Cachet-dev/storage/framework/views/403732977efb6ebb644a 6875942728eb7c1c5356.php:37

Also the settings page for Analytics gives an error 500.

I guess something was forgotten when updating to the new Laravel and the many changes to variable names.

Thanks for looking into this!

krollebol commented 6 years ago

I think I found the issue. At some places the variables have different capital letters. In resources/views/partials/analytics.blade.php: on line 34: $appAnalyticsPiwikSiteID must be $appAnalyticsPiwikSiteId

in resources/views/dashboard/settings/analytics.blade.php l38: $appAnalyticsPiwikURL must be $appAnalyticsPiwikUrl l46: $appAnalyticsPiwikSiteID must be $appAnalyticsPiwikSiteId

jbrooksuk commented 6 years ago

Sorry about that!

Are you okay to submit a Pull Request which fixes this?

jbrooksuk commented 6 years ago

Closed in #3145