This commit addresses this issue: https://github.com/CachetHQ/Cachet/…

cachethq / cachet

🚦 The open-source status page system.

https://cachethq.io

MIT License

13.93k stars 1.55k forks source link

This commit addresses this issue: https://github.com/CachetHQ/Cachet/… #4181

Closed IlyasKereibayev closed 1 year ago

IlyasKereibayev commented 3 years ago

Hello, this commit addresses this issue: https://github.com/CachetHQ/Cachet/issues/4101

I have used filter_var(), because looks like sometimes people use API as prop="false|true". And in case of "false", app counts it as true.

have a look, please

Maybe need to do the same for property "verify" in API\SubscriberController@store()?

welcome[bot] commented 3 years ago

Congratulations on opening your first Pull Request, this is a momentous day for you and us! :sparkles: To help us out, please make sure that you've followed the below:

Non-English translations should be submitted to https://translate.cachethq.io - Documentation should be submitted to https://docs.cachethq.io - Please make sure that all tests pass! - Don't worry about StyleCI, it'll fix itself on merge.

jbrooksuk commented 1 year ago

Thank you for your input on Cachet 2.x. We are shifting our attention and resources to Cachet 3.x and will no longer be supporting the 2.x version. If your feedback or issue is relevant to the 3.x series, we encourage you to engage with the new branch.

For more information on the Cachet rebuild and our plans for 3.x, you can read the announcement here.

We appreciate your understanding and look forward to your contributions to the new version.