Fix API search with pagination when specifying page

cachethq / cachet

🚦 The open-source status page system.

https://cachethq.io

MIT License

13.79k stars 1.55k forks source link

Fix API search with pagination when specifying page #4203

Closed sedan07 closed 3 years ago

sedan07 commented 3 years ago

Currently if you use the search feature of the API along with pagination, specifying the page you want (page param) Cachet throws a 500 error as it adds page and value you gave the param as a WHERE clause, even though the table in question doesn't have a page column.

Broken: /api/v1/incidents?per_page=6&page=1&status=3 Works: /api/v1/incidents?per_page=6&page=1 Works: /api/v1/incidents?per_page=6&status=1 Works: /api/v1/incidents?status=1

welcome[bot] commented 3 years ago

Congratulations on opening your first Pull Request, this is a momentous day for you and us! :sparkles: To help us out, please make sure that you've followed the below:

Non-English translations should be submitted to https://translate.cachethq.io - Documentation should be submitted to https://docs.cachethq.io - Please make sure that all tests pass! - Don't worry about StyleCI, it'll fix itself on merge.

welcome[bot] commented 3 years ago

Hooray! Your first Pull Request was merged, here's to many more :rocket:

jbrooksuk commented 3 years ago

Great, thanks!

phith0n commented 2 years ago

Hi, this commit is also a security patch, which is fix a SQL injection vulnerability.

I have sent a detail to you, release a new security advisories please.