Only use AboutApp when the setting "setting.app_about" is set

cachethq / cachet

🚦 The open-source status page system.

https://cachethq.io

MIT License

13.79k stars 1.55k forks source link

Only use AboutApp when the setting "setting.app_about" is set #4254

Closed pavog closed 3 years ago

pavog commented 3 years ago

This pr sets the AboutApp value only when the setting "setting.app_about" is set. When the setting is not set it uses an empty string instead. This fixes the error "Argument 1 passed to League\CommonMark\Converter::convertToHtml() must be of the type string, null given".

Steps to reproduce:

Clone the repo
Run phpunit

welcome[bot] commented 3 years ago

Hooray! Your first Pull Request was merged, here's to many more :rocket: