Checks if start_date has correct format before parsing the input

cachethq / cachet

🚦 The open-source status page system.

https://cachethq.io

MIT License

13.79k stars 1.55k forks source link

Checks if start_date has correct format before parsing the input #4291

Closed cfroystad closed 11 months ago

cfroystad commented 3 years ago

Currently, Cachet crashes if anyone provides a start_date that doesn't fully conform to the defined format ('Y-m-d').

This adds a check that the format matches the defined format before attempting parsing.

A future improvement could be to detect the format and use the closest valid value.

welcome[bot] commented 3 years ago

Congratulations on opening your first Pull Request, this is a momentous day for you and us! :sparkles: To help us out, please make sure that you've followed the below:

Non-English translations should be submitted to https://translate.cachethq.io - Documentation should be submitted to https://docs.cachethq.io - Please make sure that all tests pass! - Don't worry about StyleCI, it'll fix itself on merge.

MarcHagen commented 1 year ago

Missing use Carbon\Carbon;

Yes is a old PR i know, but maybe it is helpful for someone

jbrooksuk commented 11 months ago

Thank you for your input on Cachet 2.x. We are shifting our attention and resources to Cachet 3.x and will no longer be supporting the 2.x version. If your feedback or issue is relevant to the 3.x series, we encourage you to engage with the new branch.

For more information on the Cachet rebuild and our plans for 3.x, you can read the announcement here.

We appreciate your understanding and look forward to your contributions to the new version.