cachethq / cachet

🚦 The open-source status page system.

https://cachethq.io

MIT License

14.01k stars 1.56k forks source link

feat: FORCE_HTTPS_URLS env to force \URL schemes to https #4293

Closed lbennett-stacki closed 1 year ago

lbennett-stacki commented 3 years ago

For https://github.com/CachetHQ/Docker/issues/158

I have cachet behind SSL terminating load balancer. Cachet is rendering pages with assets to request using the http protocol. Browsers will block these assets if you are accessing over https, even if the asset ingress forces redirects.

welcome[bot] commented 3 years ago

Congratulations on opening your first Pull Request, this is a momentous day for you and us! :sparkles: To help us out, please make sure that you've followed the below:

Non-English translations should be submitted to https://translate.cachethq.io - Documentation should be submitted to https://docs.cachethq.io - Please make sure that all tests pass! - Don't worry about StyleCI, it'll fix itself on merge.

ChrisTG742 commented 2 years ago

We use this fix here and it's working fine. Please consider merging it into base repo.

arrfab commented 2 years ago

Came here because of the same issue and wondering when that simple fix can be merged as it seems it's affecting quite some users when running cachethq behind TLS balancer/reverse proxy. Don't know what's the best approach for the time being to easily deploy the container, maybe apply the patch and rebuild a container and so not deploy the official one ?

arrfab commented 2 years ago

some links for issues :

3952

arrfab commented 2 years ago

FWIW (for people willing to use it as container), I just built this for my own usage : https://quay.io/repository/farrotin/cachethq So basically :

using original/upstream container image
applying this patch