I just found the fix was not complete, I cannot edit issue to re-open it. Can you reopen-it?

[Artic6]

          I just found the fix was not complete, I cannot edit issue to re-open it. Can you reopen-it?

My fix is working when editing components on the dashboard. But when creating incidents, components are also updated, and email are sent

Originally posted by @ppomes in https://github.com/cachethq/cachet/issues/4395#issuecomment-2166550590

[Artic6]

Just to be clear on the requirement because this is caught me up before with issues

When you are sending an incident update and you change the status of a component I do not want those emails going to subscribers, what happens is when you have an incident update and you degrade a component? You get a component update change email you also get the actual updates that the subscribers want to read.

Then when the incident is over and resolved and change the component state back to resolved you get two further emails one with the resolved status and then another stating that the component has been updated

When sending out incident you should only be getting the instant updates you’re sending and not the additional component update emails

I originally had an issue for this but it got closed as been fixed when it’s not actually been fixed which is why it’s reopened

[Artic6]

Any updates on this?

what I’m trying to turn off as I’ve said before is when you send an incident I don’t also want the component status changes emails going

[ppomes]

Waiting to https://github.com/cachethq/cachet/pull/4403 to be merged to have a full working code.

@Jamesking56, can you have a look at this PR ?

Thanks !

[Artic6]

Am I able to manually make the change if you give me the code updates?

Lee Croucher 🐻| @.*** | w:https://a6n.co.uk http://www.a6n.co.uk/ http://facebook.com/artic6 http://us.linkedin.com/in/artic6 http://twitter.com/artic6 http://flickr.com/photos/croucher_lee http://itunes.apple.com/app/artic6 http://drive.google.com/artic6

On Fri, 21 Jun 2024 at 13:18, Pierre POMES @.***> wrote:

Waiting to #4403 https://github.com/cachethq/cachet/pull/4403 to be merged to have a full working code.

@Jamesking56 https://github.com/Jamesking56, can you have a look at this PR ?

Thanks !

— Reply to this email directly, view it on GitHub https://github.com/cachethq/cachet/issues/4400#issuecomment-2182643543, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD7S754GRAHHMA4MSZKQZDZIQK2HAVCNFSM6AAAAABJI7CKTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBSGY2DGNJUGM . You are receiving this because you authored the thread.Message ID: @.***>

[ppomes]

Three solutions in the meanwhile:

• The code update is in the PR, you can apply the same diff.
• You can clone https://github.com/ppomes/cachet
• If you are using Docker, you can pull hudson13/ppomescachet:2.4.1-20240614-1447

[Jamesking56]

Waiting to #4403 to be merged to have a full working code.

@Jamesking56, can you have a look at this PR ?

Thanks !

Did you mean to ping me or the other James 🤣

[ppomes]

Waiting to #4403 to be merged to have a full working code. @Jamesking56, can you have a look at this PR ? Thanks !

Did you mean to ping me or the other James 🤣

Lol !!! Sorry, I meant @jbrooksuk ;-)

[Artic6]

I took a look at the file referenced in your code update and I don’t seem to have this bit

function postUpdateComponent(Component $component)

it looks like you want some lines from that code removing?