search

cachethq / cachet

🚦 The open-source status page system.
https://cachethq.io
MIT License
14.09k stars 1.57k forks source link

Zombie Tags on reorder #4415

Open bwickham01 opened 2 months ago

bwickham01 commented 2 months ago

This appears to be related to issue 4403 but a slightly different presentation. We stumbled on this after seeing the [] in the blank tag fields as noted in 4403.

When a user adds a tag to any component in the list then reorders the list it applies the tag to all items. Further even if all rows in the tags and taggables tables are deleted from the database, reordering brings back the tag.

I was able to confirm this on my dev and a production instance along with the 2.4.1 demo instance (https://demo.cachethq.io/).

Steps to Reproduce

jbrooksuk commented 1 month ago

@bwickham01 does https://github.com/cachethq/cachet/pull/4403 fix this for you?

ppomes commented 1 month ago

I had exactly the same issue as @bwickham01 reported, this is why I proposed #4403.

bwickham01 commented 1 month ago

@jbrooksuk - Yes, 4403 fixes the issue for us. Thanks!