search

cachewerk / bref-laravel-bridge

An advanced Laravel integration for Bref, including Octane support.
MIT License
38 stars 8 forks source link

Check for content type starting with application/x-www-form-urlencoded #15

Closed georgeboot closed 1 year ago

georgeboot commented 2 years ago

Because content type could be application/x-www-form-urlencoded;charset=UTF-8.

It currently doesn't recognise the request as an url encoded form, and hence the form data is not available inside Laravel.

This should probably be fixed upstream as its also in Brefs PSR-7 bridge (which inspired this code).

Lastly, shouldn't we use something like https://symfony.com/doc/current/components/psr7.html#converting-objects-implementing-psr-7-interfaces-to-httpfoundation to convert the request from PSR-7 to Symfony instead?

georgeboot commented 2 years ago

Submitted https://github.com/brefphp/bref/pull/1325

georgeboot commented 2 years ago

If you agree with #16, this PR should be closed.