search

cachewerk / heroku-php-extensions

Pre-built PHP extensions for Heroku that are not included or fully supported by the official PHP buildpack.
https://php-extensions.herokuapp.com
MIT License
28 stars 5 forks source link

Can ext-openswoole be supported? #17

Closed kingIZZZY closed 2 years ago

kingIZZZY commented 2 years ago

👆

tillkruss commented 2 years ago

Yes, feel free to open a PR.

kingIZZZY commented 2 years ago

Personally have no clue how enabling these extensions for Heroku works - could it be just as simple as editing some config/build files to do "openswoole" instead of "swoole" ? Or it's (probably..) more complicated than that...

kingIZZZY commented 2 years ago

Similar question for the recently released ext-swoole (not openswoole) version 5.0.0

tillkruss commented 2 years ago

ext-openswoole needs to be added separately from ext-swoole

kingIZZZY commented 2 years ago

I can try to just clone the repo and mess around with whatever I can find, I'm just preemptively not sure what i'm doing - maybe I'm missing some important big step such as "have Ubuntu 22 and build the entire openswoole from source" or something... but oh well I can try giving it a try

tillkruss commented 2 years ago

You'll first want to add openswoole before adding Heroku-22.

kingIZZZY commented 2 years ago

For example - can I just follow the same actions as commit # https://github.com/cachewerk/heroku-php-extensions/commit/fb41db3e75d77d3c76dd2d8ebcabfd4b9094bb79 to update ext-swoole to 5.0.0? That seems like a simple starting point to try my hands at any of this... oh well let's try and see 🤷‍♂️

kingIZZZY commented 2 years ago

Alright here goes nothing #19

Next step - another PR to add support for openswoole...

kingIZZZY commented 2 years ago

And there goes another nothing #20

Next step - where to even begin about supporting heroku-22 stack?...

tillkruss commented 2 years ago

This is now building.