search

cachewerk / heroku-php-extensions

Pre-built PHP extensions for Heroku that are not included or fully supported by the official PHP buildpack.
https://php-extensions.herokuapp.com
MIT License
28 stars 5 forks source link

bump Swoole to v5.0.0 #19

Closed kingIZZZY closed 2 years ago

kingIZZZY commented 2 years ago

⚠Warning - total noob here no idea what i'm doing (as evidenced from my previous attempt... 🤦‍♂️)

Just wanted some features of the recently released swoole 5.0.0

Literally just mimicked the same changes as commit # https://github.com/cachewerk/heroku-php-extensions/commit/fb41db3e75d77d3c76dd2d8ebcabfd4b9094bb79 "bump Swoole to v4.10.0" and tried doing identical edits for v5.0.0

tillkruss commented 2 years ago

I had to revert this to v4.8.11.

Feel free to re-submit a PR. I've fixed the PR workflow to test the builds.