Swoole 5

[tillkruss]

Related #22.

The swoole builds are failing.

[kingIZZZY]

Do these build errors mean that only >= 20200930 can have swoole v5.0.0, whereas anything <= 20190902 must remain with latest swoole v4.* ?

[tillkruss]

I don't know, I'm not familiar with compiling Swoole. Somehow it's not working in that Docker image and needs fixing as of v5. Maybe a system dependency.

[kingIZZZY]

If we look at your pull request's docker image build log we see error: #error "require PHP version 8.0 or later" https://github.com/cachewerk/heroku-php-extensions/runs/7778199636?check_suite_focus=true#step:14:207

• Here by v5.0.0 it seems to say "Minimum PHP version requirement is 8.0"
• Here by v4.6.0 "No longer support PHP-7.1"
• In the README compilation instructions it says "Compiling requirements - PHP 7.2.0 or later (The higher the version, the better the performance.)"

Isn't this the issue - the PHP version, rather than other dependencies or whatever?

Does it make sense at all for this heroku repository system to have one version for earlier PHP and another version for later PHP? For example in this case we should have swoole-v4.8.11 (or whatever v4.* version it might be) for PHP < 8.0, and swoole-v5.0.0 for PHP >= 8.0 ?

[kingIZZZY]

I tried hacking together my theoretical solution: https://github.com/cachewerk/heroku-php-extensions/pull/22/commits/4f321af739520e5385fa5e4c535385c67fa52fd9 But I still can't build without the env / secrets or whatever..

Can you try building this last commit in my PR #22 ?

[tillkruss]

Does it make sense at all for this heroku repository system to have one version for earlier PHP and another version for later PHP? For example in this case we should have swoole-v4.8.11 (or whatever v4.* version it might be) for PHP < 8.0, and swoole-v5.0.0 for PHP >= 8.0 ?

I think we should do Swoole 5 on the Heroku-22 stack only.

[kingIZZZY]

OK lemme try to push a commit to that effect

I'm not sure why swoole 5 can't also work for heroku-18 and heroku-20... but let's try for now just heroku-22

[kingIZZZY]

I pushed in my PR #22 https://github.com/cachewerk/heroku-php-extensions/pull/22/commits/9dcf86df96a168ef37533171dd70ce0230dfdb06 Either way my builds always fail due to lacking env / secrets It's possible it might even work for heroku-18 and heroku-20... if you can try to run my PRs please? 🙏

[kingIZZZY]

Well congrats at least it builds For the time being I personally just need swoole 5 for heroku-22 on PHP 8.1, so this'll work for me. (Anyone on heroku-22 with PHP 8.0 though will not even have swoole 4... 🤷‍♂️)

How soon can this be released so it is usable on heroku apps?

[tillkruss]

heroku-22 is PHP 8.1+

[tillkruss]

Closing for #30.