search

cachix / devenv

Fast, Declarative, Reproducible, and Composable Developer Environments
https://devenv.sh
Apache License 2.0
3.56k stars 259 forks source link

caddy: use mainProgram for binary #892

Closed shyim closed 5 months ago

shyim commented 5 months ago

This allows exchanging caddy with a different caddy built binary but different program name. Example frankenphp in nixpkgs

I had to update the devenv.lock as in that commit that mainProgram wasn't added in nixpkgs.

domenkozar commented 5 months ago

https://www.shellcheck.net/wiki/SC2064 -- Use single quotes, otherwise this... https://www.shellcheck.net/wiki/SC3010 -- In POSIX sh, [[ ]] is undefined.

In examples/mailpit/.test.sh line 6: trap "pkill -P $DEVENV_PID" EXIT ^---------^ SC2064 (warning): Use single quotes, otherwise this expands now rather than when signalled.

For more information: https://www.shellcheck.net/wiki/SC2064 -- Use single quotes, otherwise this...

shyim commented 5 months ago

I fixed the failure in mailpit. I think it was because shellcheck got updated with the lock file change

domenkozar commented 5 months ago

There's more failures

shyim commented 5 months ago

I unified all tests scripts now:

domenkozar commented 5 months ago

last 10 log lines:

https://www.shellcheck.net/wiki/SC1091 -- Not following: /nix/var/nix/profi... https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with e.g...

In build_cloudflare.sh line 1: set -xe ^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.

For more information: https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y...

For full logs, run 'nix log /nix/store/96b5m76d34iz50bar5hzqn6k467l32a2-pre-commit-run.drv'.

shyim commented 5 months ago

So devenv ci now runs without errors

shyim commented 5 months ago

Looks the gitignore change of examples broke almost all things. Maybe we can fix that with git config advice.addIgnoredFile false 🤔

shyim commented 5 months ago

That flag fixed it. Can you trigger again the pipeline?

shyim commented 5 months ago

I had to revert the ignoring of devenv.lock. I think we would need to adjust nix itself? to not run git add on it. 🙈

shyim commented 5 months ago

So I fixed clickhouse, vault, modern-c, supported-languages. There is now something failing with ruby and rails. I have there no experience.

But more jobs are green than current main branch 😅

domenkozar commented 5 months ago

Thanks for fixing those :heart: