Transient errors shouldn't cause the action to succeed

cachix / install-nix-action

Installs Nix on GitHub Actions for the supported platforms: Linux and macOS.

Apache License 2.0

513 stars 79 forks source link

Transient errors shouldn't cause the action to succeed #113

Closed flokli closed 2 years ago

flokli commented 2 years ago

I stumbled over a GH Action that couldn't find nix-env.

Digging further up, I saw cachix/install-nix-action@v14.1 had a transient error, did retry 5 times, and then ultimately failed.

However, it didn't exit with a nonzero exit status:

flokli commented 2 years ago

This is v14.1, not v15, so I didn't check if this still occurs with v15, or whether https://github.com/cachix/install-nix-action/pull/105 fixed it.

domenkozar commented 2 years ago

v15 should fix this with --fail passed to curl and it tries indefinitely :)

flokli commented 2 years ago

Retrying indefinitely isn't that nice either - I'm not sure what the timeouts are, but we should probably fail before burning hours of CI minutes until GH Actions eventually times out…

domenkozar commented 2 years ago

Nix installation URL shouldn't be down for that long.

if it is, it would be a rare event and I'd rather burn a few dollars than waste human time restarting builds.