cachix / install-nix-action

Installs Nix on GitHub Actions for the supported platforms: Linux and macOS.
Apache License 2.0
513 stars 79 forks source link

fix ci #128

Closed domenkozar closed 2 years ago

Artturin commented 2 years ago

https://github.com/NixOS/nix/blob/03be091e0acb97a6a0d65011ec9ac8d700ec9032/scripts/install-nix-from-closure.sh#L27-L37

/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/nix-binary-tarball-unpack.XXXXXXXXXX.T6x3SPBf/unpack/nix-2.3.5-x86_64-darwin/install: macOS 11.6.4 is not supported, upgrade to 10.12.6 or higher

weirdly the following works and prints worked

#!/usr/bin/env bash

IFS='.' read -r macos_major macos_minor macos_patch << EOF
11.6.4
EOF

#echo $macos_major $macos_minor $macos_patch

if [ "$macos_major" -lt 10 ] || { [ "$macos_major" -eq 10 ] && [ "$macos_minor" -lt 12 ]; } || { [ "$macos_minor" -eq 12 ] && [ "$macos_patch" -lt 6 ]; }; then
    echo "$0: macOS X is not supported, upgrade to 10.12.6 or higher"
    exit 1
else
    echo "worked"
fi
domenkozar commented 2 years ago

https://github.com/NixOS/nix/blob/03be091e0acb97a6a0d65011ec9ac8d700ec9032/scripts/install-nix-from-closure.sh#L27-L37

/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/nix-binary-tarball-unpack.XXXXXXXXXX.T6x3SPBf/unpack/nix-2.3.5-x86_64-darwin/install: macOS 11.6.4 is not supported, upgrade to 10.12.6 or higher

weirdly the following works and prints worked

#!/usr/bin/env bash

IFS='.' read -r macos_major macos_minor macos_patch << EOF
11.6.4
EOF

#echo $macos_major $macos_minor $macos_patch

if [ "$macos_major" -lt 10 ] || { [ "$macos_major" -eq 10 ] && [ "$macos_minor" -lt 12 ]; } || { [ "$macos_minor" -eq 12 ] && [ "$macos_patch" -lt 6 ]; }; then
    echo "$0: macOS X is not supported, upgrade to 10.12.6 or higher"
    exit 1
else
    echo "worked"
fi

Do we need to fix the logic in the installer?

Artturin commented 2 years ago

i investigated further and found out that 2.3.5 does not have the commit needed for sur support https://github.com/nixos/nix/commit/14c7e77bc40d1d8055332fa5636d8a08c73039f5

the first version to have it is 2.3.8

the newest 2.3 maintenance release is 2.3.16 https://github.com/NixOS/nix/tree/2.3-maintenance

https://github.com/cachix/install-nix-action/pull/133