search

cachix / install-nix-action

Installs Nix on GitHub Actions for the supported platforms: Linux and macOS.
Apache License 2.0
513 stars 79 forks source link

fix typo in github_access_token option #153

Closed InternetUnexplorer closed 1 year ago

InternetUnexplorer commented 1 year ago

add_config only takes one argument, not two. This will cause an error when using github_access_token:

error: illegal configuration line 'access-tokens' in '/etc/nix/nix.conf'
Try 'nix-env --help' for more information.

This should (hopefully) fix that. On a sort of related note, the token passed to github_access_token will be overwritten if the user also includes access-tokens = ... in extra_nix_config (instead of merging the two); would it be worth making a PR to document this behavior in the README?

domenkozar commented 1 year ago

Documenting this would be great :)

InternetUnexplorer commented 1 year ago

Okay, I made https://github.com/cachix/install-nix-action/pull/156 :)