search

cachix / install-nix-action

Installs Nix on GitHub Actions for the supported platforms: Linux and macOS.
Apache License 2.0
526 stars 80 forks source link

Append `install_options`? #74

Open JackKelly-Bellroy opened 3 years ago

JackKelly-Bellroy commented 3 years ago

It appears that flags specified with install_options are prepended to the argument list that gets passed to the installer:

https://github.com/cachix/install-nix-action/blob/master/lib/install-nix.sh#L32

This means that the hardcoded --daemon will override any --no-daemon passed into as an install_option. Perhaps it would be better to append install_options to the end of the list?

domenkozar commented 3 years ago

It's prepending because --tarbal-url is only handled as the first argument. If we fixed that in Nix it could append.

JackKelly-Bellroy commented 3 years ago

It turns out I didn't end up needing a non-daemon install, so I'm happy to leave this open or close it or whatever.