search

cacic-fct / fct-app

Aplicativo de eventos dos alunos
https://fctapp.cacic.dev.br
Other
7 stars 4 forks source link

fix(frontend): subscription page refactor #197

Closed Yudi closed 1 week ago

Yudi commented 3 months ago

A página de inscrição foi feita às pressas, com diversos usos incorretos.

Esse pull request corrige esses anti-patterns e garante o funcionamento da página.

Closes #114 Closes #145 Closes #146

Summary by CodeRabbit

what-the-diff[bot] commented 3 months ago

Resumo do PR

Yudi commented 1 month ago

@Salies @karoldm Favor revisar, testar, corrigir e complementar o código, além de dar um cleanup, para merge na main. Como está quase tudo pronto, não precisa de muito conhecimento de Angular.

Acho que essa é a única parte do sistema que precisa de alteração para o "plano B" de usar o sistema atual

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Flag Coverage Δ
frontend_unit 47.61% <ø> (-0.96%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

coderabbitai[bot] commented 1 month ago

[!WARNING]

Rate limit exceeded

@Yudi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 29 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 2c74858439aea6d5579f2e4327408c0e24ca4eab and 9376e8d8f29367c3e9c83d695d23feb7a51c2e67.

Walkthrough

As mudanças implementadas aprimoram a funcionalidade de inscrição para eventos, introduzindo uma estrutura modular que promove a reutilização e a clareza no código. Novos componentes foram adicionados para gerenciar a exibição de informações dos eventos e a seleção do tipo de inscrição. Além disso, melhorias na validação de horários e no gerenciamento de dados em tempo real utilizando o Firestore foram realizadas, aumentando a robustez da aplicação.

Changes

Arquivo Resumo das Mudanças
frontend/src/app/app.component.scss Adição da classe CSS .opacity-50 para definir opacidade de 0.5, permitindo elementos semi-transparentes.
frontend/src/app/restricted-area/manage-events/add-event/add-event.page.ts Modificação do método validatorLatLong para utilizar operador de igualdade estrita ===, melhorando a segurança de tipos.
frontend/src/app/shared/services/major-event.service.ts Adição do novo atributo opcional mandatoryEvents ao MajorEventItem, permitindo distinção entre eventos obrigatórios e não obrigatórios.
frontend/src/app/tabs/major-events-display/subscribe/confirm-subscription-modal/confirm-subscription-modal.component.html Substituição de estrutura inline por novo componente <app-major-event-info-subscription>, melhorando a separação de preocupações; mudança no gerenciamento de eventos de eventsSelected para displayEvents$.
frontend/src/app/tabs/major-events-display/subscribe/confirm-subscription-modal/confirm-subscription-modal.component.ts Introdução de novas propriedades de entrada como events$ e modificações na forma como as seleções de eventos são gerenciadas, utilizando BehaviorSubject para melhor gerenciamento reativo.
frontend/src/app/tabs/major-events-display/subscribe/event-list-form/event-list-form.component.html Introdução de um formulário dinâmico para listar eventos, utilizando Angular Reactive Forms e async pipe para atualizações automáticas.
frontend/src/app/tabs/major-events-display/subscribe/event-list-form/event-list-form.component.scss Definição da classe CSS .twemoji para estilizar emojis, garantindo consistência visual.
frontend/src/app/tabs/major-events-display/subscribe/event-list-form/event-list-form.component.ts Implementação do componente EventListFormComponent para gerenciar inscrições em eventos, utilizando formulários reativos e lógica de seleção dinâmica.
frontend/src/app/tabs/major-events-display/subscribe/major-event-info-subscription/major-event-info-subscription.component.html Criação de template para exibir informações de eventos, utilizando componentes do Ionic para design responsivo.
frontend/src/app/tabs/major-events-display/subscribe/major-event-info-subscription/major-event-info-subscription.component.ts Criação do componente MajorEventInfoSubscriptionComponent para exibir detalhes de eventos, utilizando injeção de serviços para formatação de datas e tipos de inscrição.
frontend/src/app/tabs/major-events-display/subscribe/subscribe.page.html Substituição de lógica inline por componentes dedicados <app-major-event-info-subscription> e <app-event-list-form>, melhorando a modularidade e manutenção do código.
frontend/src/app/tabs/major-events-display/subscribe/subscribe.page.ts Integração do Firestore para gerenciamento de dados de inscrição, refatoração da lógica de inscrição e melhorias na estrutura do componente.
frontend/src/app/tabs/major-events-display/subscribe/subscribe.page.scss Remoção da classe .twemoji, simplificando o CSS.

Assessment against linked issues

Objetivo Addressed Explicação
A inscrição é efetuada sem selecionar o tipo de inscrição (#114) ✅
Verificador de choque de horário não funciona (#146) ✅
Editar inscrição não funciona (#145) ❌ Falta implementação para editar inscrições existentes.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.