Closed tdooner closed 4 years ago
@mikeubell I'm just going to merge this - it looked pretty good locally. We can check out the results when the build runs today.
This fails to calculate total_small_contributions for a candidate where there is no entry in the committees table for that candidate. See line 52 in candidate_contributions_by_type.rb
For candidates without entries in the
committees
spreadsheet tab, we still want to output their contribution list. The problem is, we store their contribution list on theCandidate
instead of their associated committee. We also muddy the waters by saving a calculation calledtotal_contributions
which is calculated differently between Candidates and Committees.This commit:
contribution_list_total
and adds fallback logic to mimic the previous implicit overwriting behaviorcommittee_data
method to Candidate to output the calculations related to the committee.