Closed ckingbailey closed 2 months ago
@ChenglimEar I think I handled all your comments. Please let me know if I overlooked or misinterpreted anything. And let me if the comments are adequate or if I should go more in depth.
@ckingbailey Sorry, it took so long to get back to this. I went through a number of PRs to get csvkit upgraded so that we can use the version of SQLAlchemy that you will need. I'm reviewing again now and hoping to approve this soon.
@ChenglimEar I've picked up changes from master.
It wasn't my intention for people to install the dependencies from both the "main" project and the "sub-project" of the downloader in one environment. That's why I made a separate requirements.txt, so that we could treat those lists of dependencies as separate.
Like with Schedule A - Contributions, this reproduces the Schedule D - Expenditures structure that was returned by the old NetFile API, and on which the Ruby backend depends.
Also included in this work: