Closed ginagr closed 4 weeks ago
You should rebase to minimize the number of commits in the request. In particular the merges from master, but also things like "revert postgres version". It is best if we only see commit messages that tell something about the changes, not intermediate steps.
You should rebase to minimize the number of commits in the request. In particular the merges from master, but also things like "revert postgres version". It is best if we only see commit messages that tell something about the changes, not intermediate steps.
Should I create a new PR with this protocol or is this just for me to be aware of for the next time?
It would me nice to rebase this. You can do it and then push (possibly specifying -f) and then merge. Not strictly necessary, but if you have time.
On Aug 15, 2024, at 3:46 PM, ggr @.***> wrote:
You should rebase to minimize the number of commits in the request. In particular the merges from master, but also things like "revert postgres version". It is best if we only see commit messages that tell something about the changes, not intermediate steps.
Should I create a new PR with this protocol or is this just for me to be aware of for the next time?
— Reply to this email directly, view it on GitHub https://github.com/caciviclab/disclosure-backend-static/pull/357#issuecomment-2292414503, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTSH6H6DULQJRGFSF6IMDDZRUVVJAVCNFSM6AAAAABMJKUTQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJSGQYTINJQGM. You are receiving this because your review was requested.
Okay, done. I rebased and also reverted the docker-compose.yml to keep postgres:15.4 rather than latest.
The build fails because of new data. I will fix the schema a bit later
On Thu, Aug 15, 2024, 4:00 PM ggr @.***> wrote:
Okay, done. I rebased and also reverted the docker-compose.yml to keep postgres:15.4 rather than latest.
— Reply to this email directly, view it on GitHub https://github.com/caciviclab/disclosure-backend-static/pull/357#issuecomment-2292425980, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTSH6DGJDLQ2XHOGTWTKO3ZRUXJ7AVCNFSM6AAAAABMJKUTQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJSGQZDKOJYGA . You are receiving this because your review was requested.Message ID: @.***>
Upgrade ruby from 2 to 3 and gems Upgrade python from 2 to 3 Upgrade postgresql from 14 to 16