search

caciviclab / disclosure-frontend

DEPRECATED (We're working on the "odca-jekyll" repo instead) California’s online source for local campaign finance data
http://www.opendisclosure.io/
MIT License
7 stars 15 forks source link

Use heroku-based API #244

Closed adborden closed 7 years ago

adborden commented 7 years ago

Use the heroku-based API which is getting updates. Hope it doesn't sleep :/

adborden commented 7 years ago

@tdooner is cloudflare hooked up to the heroku backend? If so it might be caching too aggressively. Making this code change means that we're going to hit a sleeping dyno every once in a while. Am I missing something?

tdooner commented 7 years ago

@adborden Oops, missed this during travel. I'm not sure what you mean about cloudflare, I used it to get TLS for disclosure-backend-static.tdooner.com but it isn't in use for the heroku backend since heroku has a wildcard TLS for *.herokuapp.com.

And yeah, we're going to hit sleeping dynos I guess. Personally I think the tradeoffs are worth it since dynos are otherwise somewhat expensive for our barebones project. But I could be convinced otherwise. (And I'm happy to re-host this on my personal box that never sleeps once Flynn ships a more granular permissions model that would allow caciviclab members access to deploy only this application.)

adborden commented 7 years ago

:+1: yeah, I'm referring to the old tdooner.com endpoint. I thought when you said heroku was all setup, you meant that the front end was already talking to it via some CNAME or something. Then digging into it all I could see was that it was pointing to cloudflare and unsure where it was going from there.

But sounds like this change was the correct one, I was just uncertain.