search

caciviclab / disclosure-frontend

DEPRECATED (We're working on the "odca-jekyll" repo instead) California’s online source for local campaign finance data
http://www.opendisclosure.io/
MIT License
7 stars 15 forks source link

215 2 bundle size #248

Closed KyleW closed 7 years ago

KyleW commented 7 years ago

This simplifies the gulpfile, fixes a variety of lint errors, adds ng-annotate and most importantly turns uglify back on.

This takes the app bundle size from 5.5mb to 2.8mb.

KyleW commented 7 years ago

I've made some progress. I've got minification and sourcemaps working and removed at least one redundant dependency. The bundle is down to 2.3mb before gzipping (from 5.5mb). This is worth merging as is.

However, browserify is slow! That's the new problem. Next step is to split out the vendor files into a separate bundle. And some steps to make builds faster in dev mode (incremental builds, turning off minification in dev, etc.). I'll wrap that work up in a separate pull request.

tdooner commented 7 years ago

Nice work! Probably @adborden should look at it too, but anyway this seems like a great step forward to me.

adborden commented 7 years ago

Also sorry it took me a while to get to this :)