search

caciviclab / odca-jekyll

New ODCA front end
https://www.opendisclosure.io
GNU Affero General Public License v3.0
17 stars 14 forks source link

Add election name to IEC contribution list #466

Closed mikeubell closed 10 months ago

mikeubell commented 11 months ago

This work resolves #435 Since Independent committees can raise money in one election and spend it in another, we are leaving all contributions to a committee in the list but sorting it so that the most recent election's contributions appear first. This is true even when sorting is specified on a different columng

Previews

Screen Shot 2023-12-01 at 2 54 11 PM

Screen Shot 2023-12-01 at 2 54 26 PM

mikeubell commented 10 months ago

@ckingbailey I believe I have addressed all you concerns.

ckingbailey commented 10 months ago

@mikeubell what do you want to do about the Node 18 issue?

mikeubell commented 10 months ago

I don’t feel qualified to know what the right call is. I see that this commit makes that change. I think its best to to stay as current as possible with the tools as it becomes harder to keep things running as they get older. I guess passing the flag would be the thing to do.