cacjs / cac

Simple yet powerful framework for building command-line apps.
MIT License
2.65k stars 104 forks source link

fix: stop running command with help or version flag #64

Closed haoranpb closed 4 years ago

haoranpb commented 4 years ago
# cac/example
node help.js lint --help

help.js v0.0.0

Usage:
  $ help.js lint [...files]

Options:
  --type [type]  Choose a project type (default: node)
  --name <name>  Provide your name
  -h, --help     Display this message
  -v, --version  Display version number
[] { '--': [], type: 'node', h: true, help: true } <<-- command is still running

BTW, the showVersionOnExit and showHelpOnExit may also be outdated? Since they do not actually Exit anymore.

codecov-io commented 4 years ago

Codecov Report

Merging #64 into master will decrease coverage by 0.36%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage    67.3%   66.93%   -0.37%     
==========================================
  Files           6        6              
  Lines         367      369       +2     
  Branches       91       91              
==========================================
  Hits          247      247              
- Misses        117      119       +2     
  Partials        3        3
Impacted Files Coverage Δ
src/CAC.ts 69.17% <0%> (-1.06%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d68125...0622508. Read the comment docs.

egoist commented 4 years ago

:tada: This PR is included in version 6.5.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: