search

cacjs / cac

Simple yet powerful framework for building command-line apps.
MIT License
2.65k stars 104 forks source link

Use Deno EventEmitter polyfill #66

Closed auxves closed 4 years ago

auxves commented 4 years ago

This fixes importing CAC in Deno since the events module doesn't exist there.

egoist commented 4 years ago

don't edit mod.js it's auto-generated, we should update rollup to inline events module: https://github.com/cacjs/cac/blob/master/rollup.config.js

codecov-io commented 4 years ago

Codecov Report

Merging #66 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   66.93%   66.93%           
=======================================
  Files           6        6           
  Lines         369      369           
  Branches       85       91    +6     
=======================================
  Hits          247      247           
  Misses        119      119           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 809db10...ba05af4. Read the comment docs.

auxves commented 4 years ago

@egoist I have updated the rollup config, now it replaces events with the Deno URL automatically.

egoist commented 4 years ago

:tada: This PR is included in version 6.5.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: