search

cactus / go-camo

A secure image proxy server
MIT License
255 stars 48 forks source link

Build instructions not complete #23

Closed viraptor closed 6 years ago

viraptor commented 6 years ago

Specifications

Please list the go-camo version, as well as the Operation System (and version) that go-camo is running on. The go-camo version can be found by go-camo -V.

Version: git master Platform: macos 10.13

Expected Behavior

go-camo compiles

Actual Behavior

package github.com/cactus/go-camo: no Go files in /tmp/go/src/github.com/cactus/go-camo

Steps to reproduce

Follow the README instructions:

➜  ~ export GOPATH=/tmp/go
➜  ~ go get -d github.com/cactus/go-camo
package github.com/cactus/go-camo: no Go files in /tmp/go/src/github.com/cactus/go-camo
dropwhile commented 6 years ago

That is just a warning. go get should still have checked out the code. Sounds like I should include that warning in the readme though, to be less confusing for folks.

viraptor commented 6 years ago

You're right - I assumed it was an error and didn't even check if it compiles. (It does)

dropwhile commented 6 years ago

Thanks for the report. 👍 I updated the readme to hopefully help prevent anyone from running into the same issue.