Use HTTP 200 instead of 204 for `/healthcheck`

cactus / go-camo

A secure image proxy server

MIT License

255 stars 48 forks source link

Use HTTP 200 instead of 204 for `/healthcheck` #27

Closed jacobbednarz closed 6 years ago

jacobbednarz commented 6 years ago

While testing the upgrade in two different cloud providers, I found that both of them don't respect anything other than HTTP 200 as a successful ping check (including the rest of the 2xx range).

To accomodate for the two providers, let's just use a HTTP 200 to save people doing hacky TCP checks instead.

dropwhile commented 6 years ago

sigh 🙃 Change looks good. Thanks!

jacobbednarz commented 6 years ago

🙇 appreciate the speedy response!