search

cactus / go-camo

A secure image proxy server
MIT License
254 stars 48 forks source link

Allow byte range requests to support video on Safari #37

Closed digitalmoksha closed 5 years ago

digitalmoksha commented 5 years ago

Description

Safari requires the server to respond to byte range requests in order to display video. I've added the necessary header values to ValidReqHeaders and ValidRespHeaders that need to be passed through, as well as handled the 206 status code that needs to get passed through on the response.

At the moment, it behaves the same as the 200 status code.

This is related to issue https://github.com/cactus/go-camo/issues/36

Checklist

dropwhile commented 5 years ago

This is a great start. I'll probably pull this into a branch and add a couple of tests before merging. Thanks. :)

digitalmoksha commented 5 years ago

Thanks for picking it up 👍 . I was going to tackle some tests today, but I think you can knock them out faster than I can.

dropwhile commented 5 years ago

Merged manually. Seen here: 8bf49a36707d808b180d923206ea3d0260a5bbf3

dropwhile commented 5 years ago

thanks for the PR! 👍