search

cadCAD-org / cadCAD

Design, simulate, validate, and operate within complex systems
https://cadcad.org
MIT License
549 stars 271 forks source link

Unexpected behaviour when simulating multiple configurations #248

Closed BenSchZA closed 3 years ago

BenSchZA commented 3 years ago

When adding multiple configuration objects to the global cadCAD configs list, the results are unexpected. I'm sure it relates to this statement in the docs:

As of now it does not support multi - system model simulation because configurations are still appended globally despite append_config being a method of Experiment.

https://gist.github.com/BenSchZA/7b7052ffcd65c5645d65b3e6bb56b329

At the end of the above notebook, I calculated the expected number of rows, if A/B testing was possible. This is also related to issue https://github.com/cadCAD-org/cadCAD/issues/247#issue-785165905 I believe.

JEJodesty commented 3 years ago

The previous release was returning partial results therefore a benchmark at this time is unwarranted A/B tested for future release https://github.com/cadCAD-org/cadCAD/blob/c0491800b12d3b9608b7bfbc9863680c03eae2d1/testing/tests/multi_model_row_count.py#L96 Updated Build: https://github.com/cadCAD-org/cadCAD/tree/staging

JEJodesty commented 3 years ago

Resolved by version 0.4.27